Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][Tests] should show Percentile Ranks test failure #1821

Closed
kavilla opened this issue Jun 29, 2022 · 1 comment · Fixed by #1822
Closed

[BUG][Tests] should show Percentile Ranks test failure #1821

kavilla opened this issue Jun 29, 2022 · 1 comment · Fixed by #1822
Labels
bug Something isn't working test:functional

Comments

@kavilla
Copy link
Member

kavilla commented Jun 29, 2022 •
edited
Loading

Describe the bug

should show Percentile Ranks is currently failing because it is expecting 2.036% but the value being returned is from OpenSearch is: 2.029% for this test.

To Reproduce
Steps to reproduce the behavior:

  1. Run node scripts/functional_tests.js --config test/functional/config.js --include ciGroup10

Expected behavior
The value returned from OpenSearch should be 2.036%.

OpenSearch Version
3.0 (NOTE: this test passes on 2.x and started failing on 3.x within the pass couple days)

Dashboards Version
3.0

Plugins
none

Screenshots
n/a

Host/Environment (please complete the following information):
All environments

Additional context
Link to example failure: https://github.com/opensearch-project/OpenSearch-Dashboards/runs/7119441424?check_suite_focus=true
@kavilla kavilla added bug Something isn't working untriaged test:functional and removed untriaged labels Jun 29, 2022
@dblock
Copy link
Member

dblock commented Jun 29, 2022 •
edited
Loading

This is caused by upgrading t-digest to 3.3 in opensearch-project/OpenSearch#3634. Version 3.2 was interpolating results, therefore the old number is wrong, while the new number is right, see opensearch-project/OpenSearch#3634 (comment) for an explanation.

@kavilla kavilla mentioned this issue Jun 29, 2022
Merged
1 task
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 29, 2022
@kavilla
[Tests] update expected value for percentile ranks
4fd2cd1 
Origin:
opensearch-project/OpenSearch#3634

The previous value was actually incorrect after OpenSearch bumped t-digest
the value is now the correct value.

Issue:
opensearch-project#1821

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla mentioned this issue Jun 29, 2022
Merged
7 tasks
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 29, 2022
@kavilla
[Tests] update expected value for percentile ranks
130e3eb 
Origin:
opensearch-project/OpenSearch#3634

The previous value was actually incorrect after OpenSearch bumped t-digest
the value is now the correct value.

Issue:
opensearch-project#1821

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 29, 2022
@kavilla
[Tests] update expected value for percentile ranks
3c06704 
Origin:
opensearch-project/OpenSearch#3634

The previous value was actually incorrect after OpenSearch bumped t-digest
the value is now the correct value.

Issue:
opensearch-project#1821

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit that referenced this issue Jun 30, 2022
@kavilla
[Tests] update expected value for percentile ranks (#1822)
a9984f6 
* [Tests] update expected value for percentile ranks

Origin:
opensearch-project/OpenSearch#3634

The previous value was actually incorrect after OpenSearch bumped t-digest
the value is now the correct value.

Issue:
#1821

Signed-off-by: Kawika Avilla <[email protected]>

* skip inconsistent values

Signed-off-by: Kawika Avilla <[email protected]>

* use slice

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla linked a pull request Jul 1, 2022 that will close this issue
[Tests] update expected value for percentile ranks #1822
Merged
7 tasks
@kavilla kavilla closed this as completed Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working test:functional
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Tests] update expected value for percentile ranks kavilla/OpenSearch-Dashboards-1
2 participants
@dblock @kavilla