Skip to content

Commit

Permalink
followup fixes from #5085
Browse files Browse the repository at this point in the history
Signed-off-by: Ashwin P Chandran <[email protected]>
  • Loading branch information
ashwin-pc committed Sep 28, 2023
1 parent 8d42898 commit fc3e88a
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 375 deletions.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ import { FatalErrorsSetup } from '../../../../../core/public';
* @deprecated Use `core.fatalErrors.add` instead
*/
export function addFatalError(
fatalErrors: FatalErrorsSetup,
error: Error | string,
location?: string
) {
fatalErrors.add(error, location);
}
fatalErrors: FatalErrorsSetup,
error: Error | string,
location?: string
) {
fatalErrors.add(error, location);

Check warning on line 42 in src/plugins/opensearch_dashboards_legacy/public/notify/lib/add_fatal_error.ts

View check run for this annotation

Codecov / codecov/patch

src/plugins/opensearch_dashboards_legacy/public/notify/lib/add_fatal_error.ts#L42

Added line #L42 was not covered by tests
}
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,4 @@
export { formatOpenSearchMsg } from './format_opensearch_msg';
export { formatMsg } from './format_msg';
export { formatStack } from './format_stack';
export { addFatalError } from './add_fatal_error';
2 changes: 1 addition & 1 deletion src/plugins/opensearch_dashboards_legacy/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export class OpenSearchDashboardsLegacyPlugin {
* Used to power dashboard mode. Should be removed when dashboard mode is removed eventually.
* @deprecated
*/
dashboardConfig: getDashboardConfig(!application.capabilities.dashboard.showWriteControls),
dashboardConfig: getDashboardConfig(!application.capabilities?.dashboard?.showWriteControls),
/**
* Loads the font-awesome icon font. Should be removed once the last consumer has migrated to EUI
* @deprecated
Expand Down

0 comments on commit fc3e88a

Please sign in to comment.