address comment

Signed-off-by: Su <[email protected]>
opensearch-project · Apr 5, 2023 · f059d32 · f059d32
1 parent 638b6bf
commit f059d32
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/src/plugins/console/server/routes/api/console/proxy/tests/query_string.test.ts b/src/plugins/console/server/routes/api/console/proxy/tests/query_string.test.ts
@@ -32,7 +32,7 @@ import {
   IScopedClusterClient,
   opensearchDashboardsResponseFactory,
 } from '../../../../../../../../core/server';
-import { getProxyRouteHandlerDeps, buildBufferedBodyMock } from './mocks';
+import { getProxyRouteHandlerDeps } from './mocks';
 import { createHandler } from '../create_handler';
 import { coreMock } from '../../../../../../../../core/server/mocks';
 
@@ -42,7 +42,6 @@ describe('Console Proxy Route', () => {
   beforeEach(() => {
     const requestHandlerContextMock = coreMock.createRequestHandlerContext();
     opensearchClient = requestHandlerContextMock.opensearch.client;
-    // buildBufferedBodyMock.mockResolvedValue(Buffer.from('body'));
 
     request = async (method: string, path: string) => {
       const handler = createHandler(getProxyRouteHandlerDeps({}));
@@ -64,8 +63,6 @@ describe('Console Proxy Route', () => {
       describe('contains full url', () => {
         it('treats the url as a path', async () => {
           await request('GET', 'http://evil.com/test');
-          // const res = opensearchClient.asCurrentUser.transport.request.mock.calls;
-          // console.log(res);
           const [[args]] = opensearchClient.asCurrentUser.transport.request.mock.calls;
 
           expect(args.path).toBe('/http://evil.com/test?pretty=true');

diff --git a/src/plugins/dev_tools/public/application.tsx b/src/plugins/dev_tools/public/application.tsx
@@ -154,7 +154,7 @@ function DevToolsWrapper({
 
   return (
     <main className="devApp">
-      <div className="tabNav">
+      <div>
         <EuiFlexGroup gutterSize="none">
           <EuiFlexItem>
             <EuiTabs>
@@ -178,8 +178,15 @@ function DevToolsWrapper({
           {dataSourceEnabled ? (
             <EuiFlexItem grow={false} className="dataSourceSelector">
               <EuiComboBox
-                aria-label="Select a Data Source"
-                placeholder="Select a Data Source"
+                aria-label={i18n.translate('devTool.devToolWrapper.DataSourceComboBoxAriaLabel', {
+                  defaultMessage: 'Select a Data Source',
+                })}
+                placeholder={i18n.translate(
+                  'devTool.devToolWrapper.DataSourceComboBoxPlaceholder',
+                  {
+                    defaultMessage: 'Select a Data Source',
+                  }
+                )}
                 singleSelection={{ asPlainText: true }}
                 options={dataSources}
                 selectedOptions={selectedOptions}

diff --git a/src/plugins/dev_tools/public/index.scss b/src/plugins/dev_tools/public/index.scss
@@ -22,10 +22,6 @@
   flex-grow: 1;
 }
 
-.tabNav {
-  flex-grow: 0;
-}
-
 .dataSourceSelector {
   margin: 5px 10px 5px 5px;
   min-width: 400px;