Skip to content

Commit

Permalink
Merge branch '1.x' into 1.x-bump-ajv
Browse files Browse the repository at this point in the history
Signed-off-by: Josh Romero <[email protected]>
  • Loading branch information
joshuarrrr authored May 12, 2023
2 parents 07ed49f + 364832d commit bd2214f
Show file tree
Hide file tree
Showing 33 changed files with 123 additions and 63 deletions.
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* @ananzh @kavilla @seanneumann @AMoo-Miki @ashwin-pc @joshuarrrr @abbyhu2000 @zengyan-amazon @kristenTian @zhongnansu @manasvinibs
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [CVE-2021-3803] Bump nth-check from `1.0.2` to `2.0.1` ([#3729](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3729))
- [CVE-2022-25858] Bump terser from `4.8.0` to `4.8.1` ([#3726](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3726))
- [CVE-2020-15366] Bump ajv from `4.11.8` to `6.12.6` ([#3769](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3769))
- [CVE-2021-35065] Bump glob-parent from `6.0.0` to `6.0.2` ([#3742](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3742))
- [CVE-2022-25851] Bump jpeg-js from `0.4.1` to `0.4.4` ([#3741](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3741))
- [CVE-2022-48285] Bump jszip from `3.7.1` to `3.10.1` ([#3740](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3740))

### 📈 Features/Enhancements

Expand Down Expand Up @@ -142,6 +144,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Temporary workaround for task-kill exceptions on Windows when it is passed a pid for a process that is already dead ([#2842](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2842))
- [Build] Fixed "Last Access Time" not being set by `scanCopy` on Windows ([#2964](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2964))
- Update `leaflet-vega` and fix its usage ([#3005](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3005))
- Add clarifying tooltips to header navigation ([#3573](https://github.com/opensearch-project/OpenSearch-Dashboards/issues/3573))

### 🚞 Infrastructure

Expand Down
4 changes: 2 additions & 2 deletions MAINTAINERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ This document contains a list of maintainers in this repo. See [opensearch-proje
| Maintainer | GitHub ID | Affiliation |
| ------------------------- | --------------------------------------------------- | ----------- |
| Anan Zhuang | [ananzh](https://github.com/ananzh) | Amazon |
| Bishoy Boktor | [boktorbb](https://github.com/boktorbb) | Amazon |
| Mihir Soni | [mihirsoni](https://github.com/mihirsoni) | Amazon |
| Kawika (Rocky) Avilla | [kavilla](https://github.com/kavilla) | Amazon |
| Sean Neumann | [seanneumann](https://github.com/seanneumann) | Amazon |
| Miki Barahmand | [AMoo-Miki](https://github.com/AMoo-Miki) | Amazon |
Expand All @@ -25,3 +23,5 @@ This document contains a list of maintainers in this repo. See [opensearch-proje
| Maintainer | GitHub ID | Affiliation |
| ------------- | --------------------------------------- | ----------- |
| Tommy Markley | [tmarkley](https://github.com/tmarkley) | Amazon |
| Mihir Soni | [mihirsoni](https://github.com/mihirsoni) | Amazon |
| Bishoy Boktor | [boktorbb](https://github.com/boktorbb) | Amazon |
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
"**/flat": "^5.0.2",
"**/follow-redirects": "^1.15.2",
"**/front-matter": "^4.0.2",
"**/glob-parent": "^6.0.0",
"**/glob-parent": "^6.0.2",
"**/hoist-non-react-statics": "^3.3.2",
"**/immer": "^8.0.1",
"**/istanbul-instrumenter-loader/schema-utils": "^1.0.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ The eslint config used by the opensearch dashboards team

## Usage

To use this eslint config, just install the peer dependencies and reference it
To use this eslint config, just install the peer dependencies and reference it
in your `.eslintrc`:

```javascript
Expand All @@ -17,8 +17,8 @@ in your `.eslintrc`:

## Optional jest config

If the project uses the [jest test runner](https://facebook.github.io/jest/),
the `@elastic/eslint-config-kibana/jest` config can be extended as well to use
If the project uses the [jest test runner](https://jestjs.io),
the `@elastic/eslint-config-kibana/jest` config can be extended as well to use
`eslint-plugin-jest` and add settings specific to it:

```javascript
Expand Down
2 changes: 1 addition & 1 deletion scripts/jest.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
//
// node scripts/jest --coverage
//
// See all cli options in https://facebook.github.io/jest/docs/cli.html
// See all cli options in https://jestjs.io/docs/cli

var resolve = require('path').resolve;
process.argv.push('--config', resolve(__dirname, '../src/dev/jest/config.js'));
Expand Down
2 changes: 1 addition & 1 deletion scripts/jest_integration.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
//
// node scripts/jest_integration --coverage
//
// See all cli options in https://facebook.github.io/jest/docs/cli.html
// See all cli options in https://jestjs.io/docs/cli

var resolve = require('path').resolve;
process.argv.push('--config', resolve(__dirname, '../src/dev/jest/config.integration.js'));
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion src/core/public/chrome/ui/header/header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,13 @@ export function Header({
aria-controls={navId}
ref={toggleCollapsibleNavRef}
>
<EuiIcon type="menu" size="m" />
<EuiIcon
type="menu"
size="m"
title={i18n.translate('core.ui.primaryNav.menu', {
defaultMessage: 'Menu',
})}
/>
</EuiHeaderSectionItemButton>
</EuiHeaderSectionItem>

Expand Down
10 changes: 9 additions & 1 deletion src/core/public/chrome/ui/header/header_help_menu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,15 @@ class HeaderHelpMenuUI extends Component<Props, State> {
})}
onClick={this.onMenuButtonClick}
>
<EuiIcon type="help" size="m" />
<EuiIcon type="questionInCircle" size="m" />
<EuiIcon
type="help"
size="m"
title={intl.formatMessage({
id: 'core.ui.chrome.headerGlobalNav.helpMenuButtonTitle',
defaultMessage: 'Help',
})}
/>
</EuiHeaderSectionItemButton>
);

Expand Down
2 changes: 1 addition & 1 deletion src/dev/jest/junit_reporter.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export default class JestJUnitReporter {
/**
* Called by jest when all tests complete
* @param {Object} contexts
* @param {JestResults} results see https://facebook.github.io/jest/docs/en/configuration.html#testresultsprocessor-string
* @param {JestResults} results see https://jestjs.io/docs/configuration/#testresultsprocessor-string
* @return {undefined}
*/
onRunComplete(contexts, results) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
},
"license": "Apache-2.0",
"scripts": {
"osd": "node ../../../../scripts/osd.js",
"build": "node ../../../../scripts/remove.js './target' && tsc"
"osd": "../../../../scripts/use_node ../../../../scripts/osd.js",
"build": "../../../../scripts/use_node ../../../../scripts/remove.js './target' && tsc"
},
"devDependencies": {
"@elastic/eui": "29.3.2",
Expand Down
4 changes: 2 additions & 2 deletions test/plugin_functional/plugins/app_link_test/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
},
"license": "Apache-2.0",
"scripts": {
"osd": "node ../../../../scripts/osd.js",
"build": "node ../../../../scripts/remove.js './target' && tsc"
"osd": "../../../../scripts/use_node ../../../../scripts/osd.js",
"build": "../../../../scripts/use_node ../../../../scripts/remove.js './target' && tsc"
},
"devDependencies": {
"typescript": "4.0.2"
Expand Down
4 changes: 2 additions & 2 deletions test/plugin_functional/plugins/core_app_status/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
},
"license": "Apache-2.0",
"scripts": {
"osd": "node ../../../../scripts/osd.js",
"build": "node ../../../../scripts/remove.js './target' && tsc"
"osd": "../../../../scripts/use_node ../../../../scripts/osd.js",
"build": "../../../../scripts/use_node ../../../../scripts/remove.js './target' && tsc"
},
"devDependencies": {
"typescript": "4.0.2"
Expand Down
4 changes: 2 additions & 2 deletions test/plugin_functional/plugins/core_plugin_a/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
},
"license": "Apache-2.0",
"scripts": {
"osd": "node ../../../../scripts/osd.js",
"build": "node ../../../../scripts/remove.js './target' && tsc"
"osd": "../../../../scripts/use_node ../../../../scripts/osd.js",
"build": "../../../../scripts/use_node ../../../../scripts/remove.js './target' && tsc"
},
"devDependencies": {
"typescript": "4.0.2"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
},
"license": "Apache-2.0",
"scripts": {
"osd": "node ../../../../scripts/osd.js",
"build": "node ../../../../scripts/remove.js './target' && tsc"
"osd": "../../../../scripts/use_node ../../../../scripts/osd.js",
"build": "../../../../scripts/use_node ../../../../scripts/remove.js './target' && tsc"
},
"devDependencies": {
"typescript": "4.0.2"
Expand Down
4 changes: 2 additions & 2 deletions test/plugin_functional/plugins/core_plugin_b/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
},
"license": "Apache-2.0",
"scripts": {
"osd": "node ../../../../scripts/osd.js",
"build": "node ../../../../scripts/remove.js './target' && tsc"
"osd": "../../../../scripts/use_node ../../../../scripts/osd.js",
"build": "../../../../scripts/use_node ../../../../scripts/remove.js './target' && tsc"
},
"devDependencies": {
"typescript": "4.0.2"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
},
"license": "Apache-2.0",
"scripts": {
"osd": "node ../../../../scripts/osd.js",
"build": "node ../../../../scripts/remove.js './target' && tsc"
"osd": "../../../../scripts/use_node ../../../../scripts/osd.js",
"build": "../../../../scripts/use_node ../../../../scripts/remove.js './target' && tsc"
},
"devDependencies": {
"typescript": "4.0.2"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
},
"license": "Apache-2.0",
"scripts": {
"osd": "node ../../../../scripts/osd.js",
"build": "node ../../../../scripts/remove.js './target' && tsc"
"osd": "../../../../scripts/use_node ../../../../scripts/osd.js",
"build": "../../../../scripts/use_node ../../../../scripts/remove.js './target' && tsc"
},
"devDependencies": {
"typescript": "4.0.2"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
},
"license": "Apache-2.0",
"scripts": {
"osd": "node ../../../../scripts/osd.js",
"build": "node ../../../../scripts/remove.js './target' && tsc"
"osd": "../../../../scripts/use_node ../../../../scripts/osd.js",
"build": "../../../../scripts/use_node ../../../../scripts/remove.js './target' && tsc"
},
"devDependencies": {
"typescript": "4.0.2"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
},
"license": "Apache-2.0",
"scripts": {
"osd": "node ../../../../scripts/osd.js",
"build": "node ../../../../scripts/remove.js './target' && tsc"
"osd": "../../../../scripts/use_node ../../../../scripts/osd.js",
"build": "../../../../scripts/use_node ../../../../scripts/remove.js './target' && tsc"
},
"devDependencies": {
"typescript": "4.0.2"
Expand Down
4 changes: 2 additions & 2 deletions test/plugin_functional/plugins/data_search/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
},
"license": "Apache-2.0",
"scripts": {
"osd": "node ../../../../scripts/osd.js",
"build": "node ../../../../scripts/remove.js './target' && tsc"
"osd": "../../../../scripts/use_node ../../../../scripts/osd.js",
"build": "../../../../scripts/use_node ../../../../scripts/remove.js './target' && tsc"
},
"devDependencies": {
"typescript": "4.0.2"
Expand Down
17 changes: 17 additions & 0 deletions test/plugin_functional/plugins/doc_views_links_plugin/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"name": "docViewLinksPlugin",
"version": "1.0.0",
"main": "target/test/plugin_functional/plugins/doc_views_links_plugin",
"opensearchDashboards": {
"version": "opensearchDashboards",
"templateVersion": "1.0.0"
},
"license": "Apache-2.0",
"scripts": {
"osd": "../../../../scripts/use_node ../../../../scripts/osd.js",
"build": "../../../../scripts/use_node ../../../../scripts/remove.js './target' && tsc"
},
"devDependencies": {
"typescript": "4.0.2"
}
}
4 changes: 2 additions & 2 deletions test/plugin_functional/plugins/doc_views_plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
},
"license": "Apache-2.0",
"scripts": {
"osd": "node ../../../../scripts/osd.js",
"build": "node ../../../../scripts/remove.js './target' && tsc"
"osd": "../../../../scripts/use_node ../../../../scripts/osd.js",
"build": "../../../../scripts/use_node ../../../../scripts/remove.js './target' && tsc"
},
"devDependencies": {
"typescript": "4.0.2"
Expand Down
4 changes: 2 additions & 2 deletions test/plugin_functional/plugins/index_patterns/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
},
"license": "Apache-2.0",
"scripts": {
"osd": "node ../../../../scripts/osd.js",
"build": "node ../../../../scripts/remove.js './target' && tsc"
"osd": "../../../../scripts/use_node ../../../../scripts/osd.js",
"build": "../../../../scripts/use_node ../../../../scripts/remove.js './target' && tsc"
},
"devDependencies": {
"typescript": "4.0.2"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
},
"license": "Apache-2.0",
"scripts": {
"osd": "node ../../../../scripts/osd.js",
"build": "node ../../../../scripts/remove.js './target' && tsc"
"osd": "../../../../scripts/use_node ../../../../scripts/osd.js",
"build": "../../../../scripts/use_node ../../../../scripts/remove.js './target' && tsc"
},
"devDependencies": {
"typescript": "4.0.2"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
},
"license": "Apache-2.0",
"scripts": {
"osd": "node ../../../../scripts/osd.js",
"build": "node ../../../../scripts/remove.js './target' && tsc"
"osd": "../../../../scripts/use_node ../../../../scripts/osd.js",
"build": "../../../../scripts/use_node ../../../../scripts/remove.js './target' && tsc"
},
"devDependencies": {
"typescript": "4.0.2"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
},
"license": "Apache-2.0",
"scripts": {
"osd": "node ../../../../scripts/osd.js",
"build": "node ../../../../scripts/remove.js './target' && tsc"
"osd": "../../../../scripts/use_node ../../../../scripts/osd.js",
"build": "../../../../scripts/use_node ../../../../scripts/remove.js './target' && tsc"
},
"devDependencies": {
"@elastic/eui": "29.3.2",
Expand Down
4 changes: 2 additions & 2 deletions test/plugin_functional/plugins/osd_top_nav/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
},
"license": "Apache-2.0",
"scripts": {
"osd": "node ../../../../scripts/osd.js",
"build": "node ../../../../scripts/remove.js './target' && tsc"
"osd": "../../../../scripts/use_node ../../../../scripts/osd.js",
"build": "../../../../scripts/use_node ../../../../scripts/remove.js './target' && tsc"
},
"devDependencies": {
"typescript": "4.0.2"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
},
"license": "Apache-2.0",
"scripts": {
"osd": "node ../../../../scripts/osd.js",
"build": "node ../../../../scripts/remove.js './target' && tsc"
"osd": "../../../../scripts/use_node ../../../../scripts/osd.js",
"build": "../../../../scripts/use_node ../../../../scripts/remove.js './target' && tsc"
},
"devDependencies": {
"@elastic/eui": "29.3.2",
Expand Down
4 changes: 2 additions & 2 deletions test/plugin_functional/plugins/rendering_plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
},
"license": "Apache-2.0",
"scripts": {
"osd": "node ../../../../scripts/osd.js",
"build": "node ../../../../scripts/remove.js './target' && tsc"
"osd": "../../../../scripts/use_node ../../../../scripts/osd.js",
"build": "../../../../scripts/use_node ../../../../scripts/remove.js './target' && tsc"
},
"devDependencies": {
"typescript": "4.0.2"
Expand Down
Loading

0 comments on commit bd2214f

Please sign in to comment.