[BUG] Check for duplicate data source id before fetching the data sou…

…rces in index pattern selector (#6498) (#6508)

* remove duplicate entries



* add test



---------


(cherry picked from commit d2d410b)

Signed-off-by: Lu Yu <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

src/plugins/data/public/ui/index_pattern_select/index_pattern_select.test.tsx

@@ -0,0 +1,56 @@
+/*
+ * Copyright OpenSearch Contributors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+import { shallow } from 'enzyme';
+import { SavedObjectsClientContract } from '../../../../../core/public';
+import React from 'react';
+import IndexPatternSelect from './index_pattern_select';
+
+describe('IndexPatternSelect', () => {
+  let client: SavedObjectsClientContract;
+  const bulkGetMock = jest.fn();
+
+  const nextTick = () => new Promise((res) => process.nextTick(res));
+
+  beforeEach(() => {
+    client = {
+      find: jest.fn().mockResolvedValue({
+        savedObjects: [
+          {
+            references: [{ id: 'testDataSourceId', type: 'data-source' }],
+            attributes: { title: 'testTitle1' },
+          },
+          {
+            references: [{ id: 'testDataSourceId', type: 'data-source' }],
+            attributes: { title: 'testTitle2' },
+          },
+        ],
+      }),
+      bulkGet: bulkGetMock,
+      get: jest.fn().mockResolvedValue({
+        references: [{ id: 'someId', type: 'data-source' }],
+        attributes: { title: 'testTitle' },
+      }),
+    } as any;
+  });
+
+  it('should render index pattern select', async () => {
+    const onChangeMock = jest.fn();
+    const compInstance = shallow(
+      <IndexPatternSelect
+        placeholder={'test index pattern'}
+        indexPatternId={'testId'}
+        onChange={onChangeMock}
+        data-test-subj={'testId'}
+        savedObjectsClient={client}
+      />
+    ).instance();
+
+    bulkGetMock.mockResolvedValue({ savedObjects: [{ attributes: { title: 'test1' } }] });
+    compInstance.debouncedFetch('');
+    await new Promise((resolve) => setTimeout(resolve, 300));
+    await nextTick();
+    expect(bulkGetMock).toBeCalledWith([{ id: 'testDataSourceId', type: 'data-source' }]);
+  });
+});

src/plugins/data/public/ui/index_pattern_select/index_pattern_select.tsx

@@ -172,9 +172,15 @@ export default class IndexPatternSelect extends Component<IndexPatternSelectProp
     // order than they were sent out. Only load results for the most recent search.
     if (searchValue === this.state.searchValue) {
       const dataSourcesToFetch: Array<{ type: string; id: string }> = [];
+      const dataSourceIdSet = new Set();
       savedObjects.map((indexPatternSavedObject: SimpleSavedObject<any>) => {
         const dataSourceReference = getDataSourceReference(indexPatternSavedObject.references);
-        if (dataSourceReference && !this.state.dataSourceIdToTitle.has(dataSourceReference.id)) {
+        if (
+          dataSourceReference &&
+          !this.state.dataSourceIdToTitle.has(dataSourceReference.id) &&
+          !dataSourceIdSet.has(dataSourceReference.id)
+        ) {
+          dataSourceIdSet.add(dataSourceReference.id);
           dataSourcesToFetch.push({ type: 'data-source', id: dataSourceReference.id });
         }
       });