Skip to content

Commit

Permalink
Add tooltip to help icon (#3626)
Browse files Browse the repository at this point in the history
* Add tooltip to help icon

Signed-off-by: sabina.zaripova <[email protected]>

Add tooltip to menu icon

Signed-off-by: sabina.zaripova <[email protected]>
  • Loading branch information
sayuree authored and abbyhu2000 committed Apr 17, 2023
1 parent 637d545 commit 2b004ac
Show file tree
Hide file tree
Showing 4 changed files with 35 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Temporary workaround for task-kill exceptions on Windows when it is passed a pid for a process that is already dead ([#2842](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2842))
- [Build] Fixed "Last Access Time" not being set by `scanCopy` on Windows ([#2964](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2964))
- Update `leaflet-vega` and fix its usage ([#3005](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3005))
- Add clarifying tooltips to header navigation ([#3573](https://github.com/opensearch-project/OpenSearch-Dashboards/issues/3573))

### 🚞 Infrastructure

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion src/core/public/chrome/ui/header/header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,13 @@ export function Header({
aria-controls={navId}
ref={toggleCollapsibleNavRef}
>
<EuiIcon type="menu" size="m" />
<EuiIcon
type="menu"
size="m"
title={i18n.translate('core.ui.primaryNav.menu', {
defaultMessage: 'Menu',
})}
/>
</EuiHeaderSectionItemButton>
</EuiHeaderSectionItem>

Expand Down
10 changes: 9 additions & 1 deletion src/core/public/chrome/ui/header/header_help_menu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,15 @@ class HeaderHelpMenuUI extends Component<Props, State> {
})}
onClick={this.onMenuButtonClick}
>
<EuiIcon type="help" size="m" />
<EuiIcon type="questionInCircle" size="m" />
<EuiIcon
type="help"
size="m"
title={intl.formatMessage({
id: 'core.ui.chrome.headerGlobalNav.helpMenuButtonTitle',
defaultMessage: 'Help',
})}
/>
</EuiHeaderSectionItemButton>
);

Expand Down

0 comments on commit 2b004ac

Please sign in to comment.