[Test] Enable unit test suite: schema_error.test.ts (#486) (#488)

Schema_error.test.ts is skipped due to no decision around error handling and it fails depending on Node version in 2017. There are some possible reasons: 1) nodejs is bumps to 8 in 2018 which affected error handling 2) boom is used to handle http errors which is also dependent on nodejs version. Since we forked from v7.10.2 which has a stable nodejs v10.23.1, we will enable this unit test. Signed-off-by: Anan Zhuang <[email protected]>
opensearch-project · Jun 22, 2021 · 1cf9a7a · 1cf9a7a
1 parent 4293f92
commit 1cf9a7a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/packages/osd-config-schema/src/errors/__snapshots__/schema_error.test.ts.snap b/packages/osd-config-schema/src/errors/__snapshots__/schema_error.test.ts.snap
diff --git a/packages/osd-config-schema/src/errors/schema_error.test.ts b/packages/osd-config-schema/src/errors/schema_error.test.ts
@@ -52,11 +52,7 @@ export const cleanStack = (stack: string) =>
     })
     .join('\n');
 
-// TODO This is skipped because it fails depending on Node version. That might
-// not be a problem, but I think we should wait with including this test until
-// we've made a proper decision around error handling in the new platform, see
-// https://github.com/elastic/kibana/issues/12947
-test.skip('includes stack', () => {
+it('includes stack', () => {
   try {
     throw new SchemaError('test');
   } catch (e) {