remove un-used table vis types and options

Signed-off-by: Anan Zhuang <[email protected]>
opensearch-project · Nov 2, 2022 · 09bf347 · 09bf347
1 parent a4fefe9
commit 09bf347
Show file tree

Hide file tree

Showing 10 changed files with 8 additions and 385 deletions.
diff --git a/config/opensearch_dashboards.yml b/config/opensearch_dashboards.yml
@@ -222,7 +222,7 @@
 
 # Set the value of this setting to true to start exploring wizard
 # functionality in Visualization.
-# vis_builder.enabled: false
+vis_builder.enabled: true
 
 # Set the value of this setting to true to enable the experimental multiple data source
 # support feature. Use with caution.

diff --git a/src/plugins/vis_builder/public/visualizations/table/to_expression.ts b/src/plugins/vis_builder/public/visualizations/table/to_expression.ts
@@ -143,7 +143,7 @@ export const toExpression = async ({ style: styleState, visualization }: TableRo
 
   // Update buildExpressionFunction to correctly handle optional arguments
   const tableVis = buildExpressionFunction<TableVisExpressionFunctionDefinition>(
-    'opensearch_dashboards_table_new',
+    'opensearch_dashboards_table',
     {
       visConfig: JSON.stringify(visConfig),
     }

diff --git a/src/plugins/vis_type_table_new/opensearch_dashboards.json b/src/plugins/vis_type_table_new/opensearch_dashboards.json
@@ -11,8 +11,6 @@
   "requiredBundles": [
     "opensearchDashboardsUtils",
     "opensearchDashboardsReact",
-    "charts",
-    "share",
-    "visDefaultEditor"
+    "share"
   ]
 }
diff --git a/src/plugins/vis_type_table_new/public/components/table_vis_app.tsx b/src/plugins/vis_type_table_new/public/components/table_vis_app.tsx
@@ -37,6 +37,8 @@ export const TableVisApp = ({
     visTable__groupInColumns: direction === 'column',
   });
 
+  // TODO: remove duplicate sort and width state
+  // Issue: https://github.com/opensearch-project/OpenSearch-Dashboards/issues/2704#issuecomment-1299380818
   const [sort, setSort] = useState<SortColumn>(
     handlers.uiState.get('vis.sortColumn') || { colIndex: null, direction: null }
   );

diff --git a/src/plugins/vis_type_table_new/public/components/table_vis_options.tsx b/src/plugins/vis_type_table_new/public/components/table_vis_options.tsx
diff --git a/src/plugins/vis_type_table_new/public/components/table_vis_options_lazy.tsx b/src/plugins/vis_type_table_new/public/components/table_vis_options_lazy.tsx
diff --git a/src/plugins/vis_type_table_new/public/plugin.ts b/src/plugins/vis_type_table_new/public/plugin.ts
@@ -13,7 +13,6 @@ import { Plugin as ExpressionsPublicPlugin } from '../../expressions/public';
 import { VisualizationsSetup } from '../../visualizations/public';
 
 import { createTableVisFn } from './table_vis_fn';
-import { getNewTableVisTypeDefinition } from './table_vis_type';
 import { DataPublicPluginStart } from '../../data/public';
 import { setFormatService } from './services';
 import { ConfigSchema } from '../config';
@@ -30,14 +29,10 @@ export interface TableVisPluginStartDependencies {
   data: DataPublicPluginStart;
 }
 
-const setupTableVis = async (
-  core: CoreSetup,
-  { expressions, visualizations }: TableVisPluginSetupDependencies
-) => {
+const setupTableVis = async (core: CoreSetup, { expressions }: TableVisPluginSetupDependencies) => {
   const [coreStart] = await core.getStartServices();
   expressions.registerFunction(createTableVisFn);
   expressions.registerRenderer(getTableVisRenderer(coreStart));
-  visualizations.createBaseVisualization(getNewTableVisTypeDefinition());
 };
 
 /** @internal */

diff --git a/src/plugins/vis_type_table_new/public/table_vis_fn.ts b/src/plugins/vis_type_table_new/public/table_vis_fn.ts
@@ -25,14 +25,14 @@ export interface TableVisRenderValue {
 }
 
 export type TableVisExpressionFunctionDefinition = ExpressionFunctionDefinition<
-  'opensearch_dashboards_table_new',
+  'opensearch_dashboards_table',
   Input,
   Arguments,
   Render<TableVisRenderValue>
 >;
 
 export const createTableVisFn = (): TableVisExpressionFunctionDefinition => ({
-  name: 'opensearch_dashboards_table_new',
+  name: 'opensearch_dashboards_table',
   type: 'render',
   inputTypes: ['opensearch_dashboards_datatable'],
   help: i18n.translate('visTypeTableNew.function.help', {

diff --git a/src/plugins/vis_type_table_new/public/table_vis_type.ts b/src/plugins/vis_type_table_new/public/table_vis_type.ts