Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating template for proposal #19

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Updating template for proposal #19

merged 1 commit into from
Jul 6, 2021

Conversation

jkowall
Copy link
Contributor

@jkowall jkowall commented Jul 2, 2021

Signed-off-by: Jonah Kowall [email protected]

Description

Fixing the proposal filename and comments to be more clear.

Issues Resolved

opensearch-project/OpenSearch#866

Check List

  • [X ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
Copy link
Member

dblock commented Jul 6, 2021

I'll merge this and go rebase #18 on top of it, and leave RFC as a separate proposal (paf.).

@dblock dblock merged commit 090e367 into opensearch-project:main Jul 6, 2021
@dblock
Copy link
Member

dblock commented Jul 6, 2021

I have a dumb question. For the life of me I cannot figure out how to enable this template on a repository (I'm trying on my fork in https://github.com/dblock/opensearch-project-.github/).

@jkowall jkowall deleted the proposal branch July 6, 2021 17:09
@jkowall
Copy link
Contributor Author

jkowall commented Jul 6, 2021

I have a dumb question. For the life of me I cannot figure out how to enable this template on a repository (I'm trying on my fork in https://github.com/dblock/opensearch-project-.github/).

Guessing it wasn't setup on this repo (and hence not on your fork).

https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository

I do not have admin on this repo so I cannot verify that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants