Skip to content

Commit

Permalink
Update the version of mssql used in tests
Browse files Browse the repository at this point in the history
Copying the commit message from the equivalent PR on ehrql:
opensafely-core/ehrql#2120

The previous version was incompatible with the updated kernel now used
by Github Actions runners. See:
microsoft/mssql-docker#868

The fix has been backported as far as the 2019 image, but not to the
2017 image. Seeing that the 2017 image didn't match what was being run
in production in any case we might as well upgrade.
  • Loading branch information
rebkwok committed Oct 8, 2024
1 parent 56403f6 commit 0f5220d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/databases.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def make_mssql_database(containers):
def run_mssql(container_name, containers, password, mssql_port): # pragma: no cover
containers.run_bg(
name=container_name,
image="mcr.microsoft.com/mssql/server:2017-CU25-ubuntu-16.04",
image="mcr.microsoft.com/mssql/server:2019-CU28-ubuntu-20.04",
volumes={
MSSQL_SETUP_DIR: {"bind": "/mssql", "mode": "ro"},
},
Expand Down

0 comments on commit 0f5220d

Please sign in to comment.