Use urllib3 v2
#4838
Merged
Use urllib3 v2
#4838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4715. We reverted to urllib v1 in #4806 to try and stop errors originating from OpenTelemetry's use of `urllib3`, via `requests`. Apparently these errors did not occur with `urllib3` v1 previously, but that is no longer the case, and we'll have to find another solution to stop the errors, as in #4839.
StevenMaude
force-pushed
the
steve/return-to-urllib-v2
branch
from
f3fe53c to
4f04f71
Compare
Jongmassey
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4715.
We reverted to urllib v1 in #4806 to try and stop errors originating from OpenTelemetry's use of
urllib3, viarequests.Apparently these errors did not occur with
urllib3v1 previously, but that is no longer the case, and we'll have to find another solution to stop the errors, as in #4839.