Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recipe to enable Develocity build cache for Gradle #4859

Merged
merged 15 commits into from
Jan 10, 2025
Merged

Add recipe to enable Develocity build cache for Gradle #4859

merged 15 commits into from
Jan 10, 2025

Conversation

nielsdebruin
Copy link
Contributor

@nielsdebruin nielsdebruin commented Jan 7, 2025 •
edited
Loading

What's changed?

Recipe to enable Develocity build cache, functionality is identical to Maven equivalent merged in:

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@nielsdebruin nielsdebruin added the enhancement New feature or request label Jan 7, 2025
@nielsdebruin nielsdebruin self-assigned this Jan 7, 2025
@nielsdebruin nielsdebruin changed the title Add recipe to enable Develocity build cache for gradle Add recipe to enable Develocity build cache for Gradle Jan 7, 2025
@timtebeek timtebeek self-requested a review January 7, 2025 14:02
@nielsdebruin nielsdebruin marked this pull request as ready for review January 8, 2025 13:16
github-actions[bot]
github-actions bot reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • rewrite-groovy/src/test/java/org/openrewrite/groovy/tree/VariableDeclarationsTest.java
    • lines 224-224

github-actions[bot]
github-actions bot reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • rewrite-groovy/src/test/java/org/openrewrite/groovy/tree/VariableDeclarationsTest.java
    • lines 224-224

timtebeek
timtebeek approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both! I've applied some simplifications still and with that we're good to merge.

@timtebeek timtebeek merged commit 6ff7a03 into main Jan 10, 2025
2 checks passed
@timtebeek timtebeek deleted the recipe/enable-build-cache-gradle branch January 10, 2025 13:37
sambsnyd pushed a commit that referenced this pull request Jan 15, 2025
@nielsdebruin @jevanlingen
@timtebeek @sambsnyd
Add recipe to enable Develocity build cache for Gradle (#4859)
60cf3f4 
* Add enable buildcache recipe for gradle

* Fix description

* Update test cases and rename config

* Add initial version of visitor

* Update rewrite-gradle/src/main/java/org/openrewrite/gradle/EnableDevelocityBuildCache.java

Co-authored-by: Jacob van Lingen <[email protected]>

* Indent fix

* Polish

* Change validation

* Remove linebreaks

* Simplify how build cache is created and extracted

* Only look for develocity at the root, and buildCache within that

* Show a richer example for `remotePushEnabled`

---------

Co-authored-by: Jacob van Lingen <[email protected]>
Co-authored-by: Tim te Beek <[email protected]>
sambsnyd pushed a commit that referenced this pull request Jan 15, 2025
@nielsdebruin @jevanlingen
@timtebeek @sambsnyd
Add recipe to enable Develocity build cache for Gradle (#4859)
808f292 
* Add enable buildcache recipe for gradle

* Fix description

* Update test cases and rename config

* Add initial version of visitor

* Update rewrite-gradle/src/main/java/org/openrewrite/gradle/EnableDevelocityBuildCache.java

Co-authored-by: Jacob van Lingen <[email protected]>

* Indent fix

* Polish

* Change validation

* Remove linebreaks

* Simplify how build cache is created and extracted

* Only look for develocity at the root, and buildCache within that

* Show a richer example for `remotePushEnabled`

---------

Co-authored-by: Jacob van Lingen <[email protected]>
Co-authored-by: Tim te Beek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jevanlingen jevanlingen jevanlingen left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@timtebeek timtebeek timtebeek approved these changes

@shanman190 shanman190 Awaiting requested review from shanman190

Assignees

@nielsdebruin nielsdebruin

Labels
enhancement New feature or request
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nielsdebruin @timtebeek @jevanlingen @shanman190