Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Groovy parsers should be able to support .class #4824

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Groovy parsers should be able to support .class #4824

merged 2 commits into from
Dec 31, 2024

Conversation

jevanlingen
Copy link
Contributor

@jevanlingen jevanlingen commented Dec 31, 2024 •
edited
Loading

What's changed?

Support JavaStyle .class suffix.

What's your motivation?

Though the suffix is optional in Groovy, you can still use them, see for example: SchemaZipPlugin.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@jevanlingen jevanlingen added enhancement New feature or request parser-groovy labels Dec 31, 2024
@jevanlingen jevanlingen self-assigned this Dec 31, 2024
@jevanlingen jevanlingen mentioned this pull request Dec 31, 2024
Merged
3 tasks
@jevanlingen jevanlingen merged commit 2b8cdd0 into main Dec 31, 2024
2 checks passed
@jevanlingen jevanlingen deleted the groovy-parser-support-class branch December 31, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

@nielsdebruin nielsdebruin Awaiting requested review from nielsdebruin

Assignees

@jevanlingen jevanlingen

Labels
enhancement New feature or request parser-groovy
Projects
OpenRewrite
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jevanlingen @timtebeek