Tolerate missing pom when jar is present #4777
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rewrite-maven/src/test/java/org/openrewrite/maven/tree/ResolvedPomTest.java
Outdated
Show resolved
Hide resolved
rewrite-maven/src/test/java/org/openrewrite/maven/tree/ResolvedPomTest.java
Outdated
Show resolved
Hide resolved
|
We likely need a mix of the approach (or at least the tests) seen here and in #4738; as right now we repeatedly attempt to download the same pom, because the failure to resolve is not stored in the pom cache. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Catch a failure to download a pom in ResolvedPom, and if caught check to see if the corresponding jar can be found. If so, continue without issue.
What's your motivation?
Anything in particular you'd like reviewers to focus on?
MavenArtifactDownloaderhad previously been unused for quite a while; figured to bring that back here to check for jar availability. We could possibly move that to the same package as MavenPomDownloader, such that we don't need:MavenPomDownloader.distinctNormalizedRepositorieschanged topublic, as we need to look across all repositories for the.jarfile. Not just the ones defined in theResolvedPom.Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
There is an alternative implementation in
That chose the route of having changes mostly in MavenPomDownloader, which then also looks at jars and if so returns a dummy pom.xml; I think it's better not to mix responsibilities there, nor to continue processing a known dummy pom.