Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure provided download target exist before writing files to it #4762

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

lkerford
Copy link
Contributor

@lkerford lkerford commented Dec 9, 2024

What's changed?

When we use the default download location we create the folder if it is missing. We also need to do this if a custom location is provided

What's your motivation?

If the custom location is not created, the recipe which requires the associated resources will fail because it cannot find the associated resources

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

When we use the default download location we create the folder if it is missing. We also need to do this if a custom location is provided
@lkerford lkerford merged commit 1095923 into main Dec 9, 2024
2 checks passed
@lkerford lkerford deleted the create-missing-folders branch December 9, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants