Fix Gradle/Groovy parser issue related to Java class references #4742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laurens-W
commented
Dec 4, 2024
| @@ -1374,7 +1374,7 @@ public void visitConstantExpression(ConstantExpression expression) { | |||
| public void visitConstructorCallExpression(ConstructorCallExpression ctor) { | |||
| queue.add(insideParentheses(ctor, fmt -> { | |||
| cursor += 3; // skip "new" | |||
| TypeTree clazz = visitTypeTree(ctor.getType(), ctor.getMetaDataMap().containsKey(StaticTypesMarker.INFERRED_TYPE)); | |||
| TypeTree clazz = visitTypeTree(ctor.getType(), ctor.getNodeMetaData().containsKey(StaticTypesMarker.INFERRED_TYPE)); | |||
There was a problem hiding this comment.
Same way of retrieving the metadata is used a few lines later
knutwannheden
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Use different way of retrieving metadata map
Anyone you would like to review specifically?
@sambsnyd @timtebeek @knutwannheden
Any additional context
Exception that was being swallowed:
java.lang.NoSuchMethodError: org.codehaus.groovy.ast.expr.ConstructorCallExpression.getMetaDataMap()Ljava/util/Map;Checklist