Add RegExp support to ChangeTagValue recipe #4733
Open
+327
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 29, 2024 00:58
Plus some refactoring
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Some suggestions could not be made:
- rewrite-core/src/main/java/org/openrewrite/internal/AdaptiveRadixTree.java
- lines 594-594
- rewrite-core/src/main/java/org/openrewrite/internal/lang/NonNull.java
- lines 18-18
- lines 43-43
- rewrite-xml/src/main/java/org/openrewrite/xml/ChangeTagValueVisitor.java
- lines 98-98
rewrite-xml/src/main/java/org/openrewrite/xml/ChangeTagValue.java
Outdated
Show resolved
Hide resolved
rewrite-xml/src/main/java/org/openrewrite/xml/ChangeTagValueVisitor.java
Outdated
Show resolved
Hide resolved
rewrite-xml/src/test/java/org/openrewrite/xml/ChangeTagValueTest.java
Outdated
Show resolved
Hide resolved
rewrite-xml/src/test/java/org/openrewrite/xml/ChangeTagValueTest.java
Outdated
Show resolved
Hide resolved
| ) | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } |
Impl. SAST suggestions
|
@timtebeek / @gadams00 Can you kindly help with this change? Thanks! |
| new ChangeTagValue("/dependency/version", | ||
| "SNAPSHOT", "RELEASE", Boolean.TRUE) | ||
| ), | ||
| xml(""" |
There was a problem hiding this comment.
Suggested change
| xml(""" | |
| xml( | |
| """ |
| new ChangeTagValue("/dependency/version", | ||
| "$", "-RELEASE", Boolean.TRUE) | ||
| ), | ||
| xml(""" |
There was a problem hiding this comment.
Suggested change
| xml(""" | |
| xml( | |
| """ |
| new ChangeTagValue("/dependency/version", | ||
| "(\\d).(\\d).(\\d)", "$1.$3.4", Boolean.TRUE) | ||
| ), | ||
| xml(""" |
There was a problem hiding this comment.
Suggested change
| xml(""" | |
| xml( | |
| """ |
| ) | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } |
| ) | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Allows ChangeTagValue to take in regex in
oldValueparameter.What's your motivation?
Anything in particular you'd like reviewers to focus on?
Please leave your thoughts here or on the issue #4731.
Anyone you would like to review specifically?
@timtebeek? - Because I see you actively replying ;)
@gadams00 - Because, history.
Have you considered any alternatives or workarounds?
Not really. I found this to be more appealing.
Checklist