Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore ListUtils map methods that accept UnaryOperator #4729

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Restore ListUtils map methods that accept UnaryOperator #4729

merged 2 commits into from
Nov 28, 2024

Conversation

timtebeek
Copy link
Contributor

We're understandably getting reports that older recipe jars now can not run, following

This restores those methods for now, but also locks us into new compilations again using the implied old methods. 🤔

@timtebeek timtebeek added the bug Something isn't working label Nov 28, 2024
@timtebeek timtebeek self-assigned this Nov 28, 2024
@timtebeek timtebeek mentioned this pull request Nov 28, 2024
Closed
pstreef
pstreef approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@pstreef pstreef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you tested that cast? Looks like this will fix our problem!

@timtebeek timtebeek merged commit 7f43cc1 into main Nov 28, 2024
2 checks passed
@timtebeek timtebeek deleted the restore-listutils-map-UnaryOperator branch November 28, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pstreef pstreef pstreef approved these changes

@knutwannheden knutwannheden Awaiting requested review from knutwannheden

@jevanlingen jevanlingen Awaiting requested review from jevanlingen

Assignees

@timtebeek timtebeek

Labels
bug Something isn't working
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timtebeek @pstreef