Restrict usage of RecipeList methods from ScanningRecipe
#4712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
deleted the
restrict-RecipleList-methods-for-ScanningRecipes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Make
getRecipeListandbuildRecipeListfinalinScanningRecipe.What's your motivation?
Frequent source of confusion among users as the scanning conditions are not applied to these methods. Figured by making it explicit that this pattern is not expected or supported we'd see fewer questions like
Anything in particular you'd like reviewers to focus on?
Any valid cases I'd missed that should support this still?