TypeUtils#isAssignable() improvements
#4696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to consider the "position" when performing the assignability check. I.e. check if a parameterized type compared against a generic type variable is used in a context where the generic type parameter is bound by the parameterized type or not.
knutwannheden
changed the title
TypeUtils#isAssignable() improvements
3 tasks
MBoegers
pushed a commit
to MBoegers/rewrite
that referenced
this pull request
Dec 18, 2024
* Add `TypeUtils` tests for primitives * Correct `TypeUtils#isAssignableTo()` for primitive array types * New `TypeUtils#isAssignableTo()` API We need to consider the "position" when performing the assignability check. I.e. check if a parameterized type compared against a generic type variable is used in a context where the generic type parameter is bound by the parameterized type or not. * Implement new API * Remove one more `stream()` call * Update Javadoc visitors to use `TypeUtils#isAssignableTo()` correctly * Correction * Corrections * Corrections * More Javadoc fixes * Add missing `@MinimumJava11` annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeUtils#isAssignable()is used by many different recipes. One complexity that up until now hadn't been considered is that the assignability check when also considering the call-site variance. For example, checking ifjava.util.List<String>can be assigned to<T extends java.util.Collection<String>>depends a lot on where that<T>is declared (e.g. as the parameter or return type of a method or the type of a local variable). The API new allows the caller to provide an additionalTypePositionparameter to indicate this.