Add AddAnnotationProcessor recipe
#4694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rewrite-maven/src/test/java/org/openrewrite/maven/AddAnnotationProcessorTest.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Nov 20, 2024
rewrite-maven/src/main/java/org/openrewrite/maven/AddAnnotationProcessor.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Nov 20, 2024
rewrite-maven/src/main/java/org/openrewrite/maven/AddAnnotationProcessor.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Nov 20, 2024
rewrite-maven/src/main/java/org/openrewrite/maven/AddAnnotationProcessor.java
Outdated
Show resolved
Hide resolved
reverse arguments on equal check so no null checks are needed Adjust name and desc to match recipe
timtebeek
reviewed
Nov 24, 2024
| <path> | ||
| <groupId>org.projectlombok</groupId> | ||
| <artifactId>lombok-mapstruct-binding</artifactId> | ||
| <version>0.1.0</version> |
There was a problem hiding this comment.
I'd intentionally changed this to use a mismatched version; should we perhaps override any existing version here? Or only when lower than the version we're intended to add?
timtebeek
reviewed
Nov 24, 2024
There was a problem hiding this comment.
Elsewhere we have similar classes in src/main as well; makes for nicer usage to move this up now as well.
timtebeek
reviewed
Nov 24, 2024
rewrite-maven/src/main/java/org/openrewrite/maven/AddAnnotationProcessor.java
Outdated
Show resolved
Hide resolved
timtebeek
approved these changes
Nov 24, 2024
timtebeek
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Introduce new recipe for adding annotation processors to the maven compiler plugin
What's your motivation?
lombok-mapstruct-bindingduring Java 17 migration when both lombok and mapstruct are used rewrite-migrate-java#610relies on adding the annotation processor for both maven and gradle
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
@timtebeek
Checklist