Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find Refaster style recipes as well #4693

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Find Refaster style recipes as well #4693

merged 1 commit into from
Nov 20, 2024

Conversation

timtebeek
Copy link
Contributor

What's changed?

Find Refaster style recipes as well; through proxy of @RecipeDescriptor.

What's your motivation?

Be able to analyze the recipes we have, and potentially train on those found.

Anything in particular you'd like reviewers to focus on?

Added a new RecipeType.Refaster; figured that be easier than an @Option.

Have you considered any alternatives or workarounds?

  • Separate recipe: more work to maintain.
  • An option: needs repeated recipe runs.
  • Match @AfterTemplate; would then also match those from Picnic, but those lack a guaranteed name & description, making them harder to train on.

Any additional context

@timtebeek timtebeek added the enhancement New feature or request label Nov 20, 2024
@timtebeek timtebeek self-assigned this Nov 20, 2024
@timtebeek
Copy link
Contributor Author

@justine-gehring Let me know if this would be helpful, and then we can do Yaml recipes next.

@sambsnyd sambsnyd merged commit 284e5f6 into main Nov 20, 2024
2 checks passed
@sambsnyd sambsnyd deleted the find-refaster-recipes branch November 20, 2024 20:54
MBoegers pushed a commit to MBoegers/rewrite that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants