Fix bug using AddOrUpdateAnnotationAttribute
on annotation with empty brackets
#4672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Fixed bug that caused incorrect code when
AddOrUpdateAnnotationAttribute
on annotation with empty bracket e.g.,@Foo()
.What's your motivation?
The recipe
AddOrUpdateAnnotationAttribute
can be used to modify the attribute values on annotation. When no attribute values have been specified, the recipe will work fine if the syntax@Foo
is used. However, if@Foo()
is used, which is also valid java. Then, the recipe breaks.Example
If we run
AddOrUpdateAnnotationAttribute
onA
annotated with@Foo
, configured to set the value ofFoo.array
to "newTest1,newTest2" we correctly get:Yet applying it to
@Foo()
, incorrectly yieldsAnything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist