cleanup temp remote artifact #4568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natedanner
force-pushed
the
cleanup-gradle-tmp
branch
from
9c777c3 to
fdc557d
Compare
sjungling
approved these changes
Oct 10, 2024
sambsnyd
reviewed
Oct 10, 2024
rewrite-core/src/main/java/org/openrewrite/remote/LocalRemoteArtifactCache.java
Outdated
Show resolved
Hide resolved
natedanner
force-pushed
the
cleanup-gradle-tmp
branch
from
fdc557d to
cffb16f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Move cleanup of temporary artifact in the put method of
LocalRemoteArtifactCache.javato the finally block.What's your motivation?
Having disk fill up in the Moderne SaaS on a large run that is updating gradle wrappers.
Related to: https://github.com/moderneinc/customer-requests/issues/620
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
@sambsnyd
Checklist