Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use reflection to invoke getCommentTree to support Java 21 & 23 #4555

Merged
merged 2 commits into from
Oct 6, 2024
Merged

Use reflection to invoke getCommentTree to support Java 21 & 23 #4555

merged 2 commits into from
Oct 6, 2024

Conversation

timtebeek
Copy link
Contributor

@timtebeek timtebeek self-assigned this Oct 6, 2024
@timtebeek timtebeek added bug Something isn't working enhancement New feature or request labels Oct 6, 2024
@timtebeek timtebeek mentioned this pull request Oct 6, 2024
Closed
@Col-E
Copy link

Col-E commented Oct 6, 2024

Built 8.37.0-SNAPSHOT locally and can no longer reproduce #4540

👍

@timtebeek timtebeek merged commit b5f6eae into main Oct 6, 2024
2 checks passed
@timtebeek timtebeek deleted the use-reflection-to-invoke-getCommentTree branch October 6, 2024 15:53
@timtebeek
Copy link
Contributor Author

Thanks a lot for confirming, and the guidance in #4540 ! We'll do another release this Wednesday to hopefully finally see this resolved. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knutwannheden knutwannheden Awaiting requested review from knutwannheden

Assignees

@timtebeek timtebeek

Labels
bug Something isn't working enhancement New feature or request
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rewrite-java-21 (8.36.0) fails on Java 23
2 participants
@timtebeek @Col-E