Handle plugins without groupId #4507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DidierLoiseau
commented
Sep 20, 2024
| plugins.add(new org.openrewrite.maven.tree.Plugin( | ||
| rawPlugin.getGroupId(), | ||
| pluginGroupId == null ? PLUGIN_DEFAULT_GROUPID : pluginGroupId, |
There was a problem hiding this comment.
I don’t see a way to set it anywhere else because the field is final in the raw plugin, and the constructors are generated by Lombok.
Jackson does not seem to have default value handling either.
timtebeek
approved these changes
Sep 20, 2024
|
Thanks for the many fixes! I've just put out a new patch release: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Handle the default value of plugin
groupIdas per https://maven.apache.org/xsd/maven-4.0.0.xsdSee also is groupId required for plugins in Maven pom.xml? on Stack Overflow.
What's your motivation?
Someone declared a plugin without groupId…
Have you considered any alternatives or workarounds?
It would be possible to fix just
RemoveRedundantDependencyVersions, but since this default value is defined in the xsd, I thought it would be better to fix the parsing/resolution.Any additional context
It was causing an invisible NPE in
RemoveRedundantDependencyVersionsfor thepluginManagementcase. I’m not sure how such exceptions should be handled.Theoretically the
artifactIdis optional as well, but I don’t see why anyone wouldn’t provide it. Moreover there isn’t a default for it.Checklist