Handle bom import in RemoveDuplicateDependencies #4504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DidierLoiseau
commented
Sep 19, 2024
| @@ -125,6 +125,9 @@ private boolean isManagedDependenciesTag() { | |||
| } | |||
|
|
|||
| private @Nullable DependencyKey getManagedDependencyKey(Xml.Tag tag) { | |||
| if (tag.getChildValue("scope").map("import"::equalsIgnoreCase).orElse(false)) { | |||
| return DependencyKey.from(tag); | |||
| } | |||
| ResolvedManagedDependency resolvedDependency = findManagedDependency(tag); | |||
There was a problem hiding this comment.
findManagedDependency() does not actually find imported boms. It seems they are not included in dependency management by the resolver.
timtebeek
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Thanks a lot for yet another improvement @DidierLoiseau ; Must say I really appreciate your thorough work! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Added support for
<scope>import</scope>inRemoveDuplicateDependenciesWhat's your motivation?
It seems we have duplicate imports in our poms 😏
Have you considered any alternatives or workarounds?
I don’t really see any.
Checklist