Remove redundant versions for Gradle #4492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rewrite-gradle/src/main/java/org/openrewrite/gradle/RemoveRedundantDependencyVersions.java
Show resolved
Hide resolved
rewrite-gradle/src/test/java/org/openrewrite/gradle/RemoveRedundantDependencyVersionsTest.java
Show resolved
Hide resolved
rewrite-gradle/src/test/java/org/openrewrite/gradle/RemoveRedundantDependencyVersionsTest.java
Outdated
Show resolved
Hide resolved
shanman190
force-pushed
the
feature/gradle-remove-redundant-versions
branch
from
9381432 to
a70e429
Compare
|
The implementation here is now handling everything except for freestanding scripts which like the other recipes is also spotty for support anyway. |
|
The one failing test as described earlier. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…pe to the current buildscript only
…onfigurations. Include fix for ChangeDependencyClassifier for G.MapLiteral types
shanman190
force-pushed
the
feature/gradle-remove-redundant-versions
branch
from
2abf042 to
630cf5f
Compare
Comment on lines
+124
to
+125
| public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, ExecutionContext p) { | ||
| J.MethodInvocation m = super.visitMethodInvocation(method, p); |
There was a problem hiding this comment.
Suggested change
| public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, ExecutionContext p) { | |
| J.MethodInvocation m = super.visitMethodInvocation(method, p); | |
| public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx) { | |
| J.MethodInvocation m = super.visitMethodInvocation(method, ctx); |
Comment on lines
+137
to
+138
| MavenPomDownloader mpd = new MavenPomDownloader(p); | ||
| try { |
There was a problem hiding this comment.
Suggested change
| MavenPomDownloader mpd = new MavenPomDownloader(p); | |
| try { | |
| MavenPomDownloader mpd = new MavenPomDownloader(ctx); | |
| .resolve(Collections.emptyList(), mpd, ctx); |
Comment on lines
+183
to
+184
| MavenPomDownloader mpd = new MavenPomDownloader(p); | ||
| try { |
There was a problem hiding this comment.
Suggested change
| MavenPomDownloader mpd = new MavenPomDownloader(p); | |
| try { | |
| MavenPomDownloader mpd = new MavenPomDownloader(ctx); | |
| .resolve(Collections.emptyList(), mpd, ctx); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Add recipe to remove redundant versions.
What's your motivation?
A similar feature is available in Maven.
Anything in particular you'd like reviewers to focus on?
Nothing in particular
Anyone you would like to review specifically?
Anybody
Have you considered any alternatives or workarounds?
Forcibly removing versions would result in broken builds.
Any additional context
Checklist