Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of inner classes #4483

Merged
merged 7 commits into from
Sep 16, 2024
Merged

Conversation

Laurens-W
Copy link
Contributor

What's changed?

Improved handling of inner classes

What's your motivation?

https://rewriteoss.slack.com/archives/C01A843MWG5/p1725947336140549

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

@timtebeek

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@Laurens-W Laurens-W added the bug Something isn't working label Sep 11, 2024
@Laurens-W Laurens-W requested a review from timtebeek September 11, 2024 08:51
@Laurens-W Laurens-W self-assigned this Sep 11, 2024
@Laurens-W Laurens-W marked this pull request as ready for review September 11, 2024 09:18
@Laurens-W Laurens-W marked this pull request as draft September 11, 2024 12:50
@Laurens-W Laurens-W marked this pull request as ready for review September 16, 2024 14:03
@Laurens-W
Copy link
Contributor Author

Running it against OR using the cli no longer gives any problematic changesets, currently running a different recipe against Spring but can do this one too after that

@Laurens-W Laurens-W requested a review from timtebeek September 16, 2024 15:32
@timtebeek timtebeek merged commit 525f368 into main Sep 16, 2024
2 checks passed
@timtebeek timtebeek deleted the order-imports-nested-class branch September 16, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants