Add DoesNotUseType recipe for use in preconditions to reject source files #4471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rewrite-java/src/test/java/org/openrewrite/java/search/NotUsesTypeTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
timtebeek
reviewed
Sep 4, 2024
rewrite-java/src/test/java/org/openrewrite/java/search/NotUsesTypeTest.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Sep 4, 2024
rewrite-java/src/test/java/org/openrewrite/java/search/NotUsesTypeTest.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Sep 4, 2024
rewrite-java/src/main/java/org/openrewrite/java/search/NotUsesType.java
Outdated
Show resolved
Hide resolved
timtebeek
changed the title
timtebeek
approved these changes
Sep 4, 2024
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's your motivation?
This recipe is required to be used as a precondition for JUnit 4 to 5 migration, which we don't want to do if any TestNG type is used
Anything in particular you'd like reviewers to focus on?
Test coverage
Anyone you would like to review specifically?
@timtebeek
Have you considered any alternatives or workarounds?
Any additional context
Checklist