Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static constructor for GitRemote.Service from any previously used name formats #4469

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

pstreef
Copy link
Contributor

@pstreef pstreef commented Sep 4, 2024

What's changed?

Add a static constructor for GitRemote.Service

What's your motivation?

There are a few different places where different cases have been used in configurations like BITBUCKET_CLOUD or BitbucketCloud and it would be nice to have a single helper method to initiate a service.

Have you considered any alternatives or workarounds?

Doing this on the consuming side

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@pstreef pstreef merged commit 1cf7a3a into main Sep 4, 2024
2 checks passed
@pstreef pstreef deleted the feat/service-for-name branch September 4, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants