Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore case on GitRemote equals #4468

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Ignore case on GitRemote equals #4468

merged 3 commits into from
Sep 4, 2024

Conversation

pstreef
Copy link
Contributor

@pstreef pstreef commented Sep 4, 2024 •
edited
Loading

What's changed?

Ignore case on GitRemote string fields

What's your motivation?

A git clone URL should be compared case insensivive. All fields (except service) are derivatives

Have you considered any alternatives or workarounds?

no

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@pstreef pstreef merged commit 153700c into main Sep 4, 2024
2 checks passed
@pstreef pstreef deleted the feat/ignore-case-equals-gitremote branch September 4, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pstreef @timtebeek