Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: No protocol in origin #4435

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix: No protocol in origin #4435

merged 1 commit into from
Aug 21, 2024

Conversation

pstreef
Copy link
Contributor

@pstreef pstreef commented Aug 21, 2024

What's changed?

Strip the protocol when adding a git remote with a single origin string

What's your motivation?

We dont want protocols in origins

Anyone you would like to review specifically?

@bryceatmoderne

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@pstreef pstreef added the bug Something isn't working label Aug 21, 2024
@pstreef pstreef requested a review from bryceatmoderne August 21, 2024 13:58
@pstreef pstreef self-assigned this Aug 21, 2024
@pstreef pstreef merged commit 32a14d7 into main Aug 21, 2024
2 checks passed
@pstreef pstreef deleted the fix/no-protocol-in-origin branch August 21, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryceatmoderne bryceatmoderne bryceatmoderne approved these changes

Assignees

@pstreef pstreef

Labels
bug Something isn't working
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pstreef @bryceatmoderne