Groovy issues with Strings in parentheses #4431
Conversation
| // On Java 8 _INSIDE_PARENTHESES_LEVEL is a regular Integer | ||
| insideParenthesesLevel = (Integer) rawIpl; | ||
| } | ||
| Integer insideParenthesesLevel = getInsideParenthesesLevel(node); |
There was a problem hiding this comment.
This is where we still see a difference between Groovy 2.5 and 3+;
- on 3+ the ConstantExpression has a metaDataMap containing
_INSIDE_PARENTHESES_LEVEL: 1 - on 2.5 the ConstantExpression lacks a metaDataMap
We then either enter (for 3+) the below if, or skip it for 2.5, meaning the cursor positions are not updated there through the call to whitespace().
Eventually the 2.5 parser then fails with:
java.lang.AssertionError: Source file was parsed into an LST that contains non-whitespace characters in its whitespace. This is indicative of a bug in the parser.
def a = (~~(non-whitespace)~~>"-")<~~
| return ((AtomicInteger) rawIpl).get(); | ||
| } else { | ||
| // On Java 8 _INSIDE_PARENTHESES_LEVEL is a regular Integer | ||
| return (Integer) rawIpl; |
There was a problem hiding this comment.
I'm not seeing any evidence that this is ever triggered on Groovy 2.5; might need to change how we detect and handle parentheses for that version.
|
I'd like to get this smaller increment in already, as this fixes things for Gradle 7+, before continuing to explore a fix for older gradle versions too. Then we can already do a patch release to get the first fixes out. |
|
Merging already for the fix to |
What's changed?
What's your motivation?
Resolve Groovy parser issues affecting Gradle projects ;
some of the tests here fare worse on Groovy 2.5.
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context