Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct length for GString substrings #4430

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Use correct length for GString substrings #4430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rewrite-groovy/src/main/java/org/openrewrite/groovy/GroovyParserVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1457,7 +1457,7 @@ public void visitGStringExpression(GStringExpression gstring) {
// The sub-strings within a GString have no delimiters of their own, confusing visitConstantExpression()
// ConstantExpression.getValue() cannot be trusted for strings as its values don't match source code because sequences like "\\" have already been replaced with a single "\"
// Use the AST element's line/column positions to figure out its extent, but those numbers need tweaks to be correct
int length = sourceLengthOfString(cs);
int length = lengthAccordingToAst(cs);
if (i == 0 || i == rawExprs.size() - 1) {
// The first and last constants within a GString have line/column position which incorrectly include the GString's delimiters
length -= delimiter.length();
Expand Down
Loading