Restore newArtifactId property in ChangePluginGroupIdAndArtifactId #4421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
reviewed
Aug 15, 2024
Comment on lines
+64
to
71
| @Option(displayName = "New artifact ID", | ||
| description = "The new artifact ID to use. Defaults to the existing artifact ID. This property is deprecated, use newArtifactId instead.", | ||
| example = "my-new-maven-plugin", | ||
| required = false) | ||
| @Nullable | ||
| @Deprecated | ||
| @SuppressWarnings("DeprecatedIsStillUsed") | ||
| String newArtifact; |
There was a problem hiding this comment.
Thanks for taking the extra effort to remain backwards compatible; I ran a quick search to see if anything used the constructor, but thankfully that does not seem to be the case. https://app.moderne.io/results/MSJWn0HY8
Via a run of org.openrewrite.java.search.FindMethods with methodPattern *..ChangePluginGroupIdAndArtifactId <constructor>(..) against the OpenRewrite GitHub org.
Merged
timtebeek
approved these changes
Aug 15, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was mistakenly changed here:
https://github.com/openrewrite/rewrite/pull/3843/files#diff-a3496299541c5119d2fd48e331f97b62173789f41a9ec4f5f25f9e8454ab7518R59
I made sure we don't break people who are using
newArtifact.