Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow deserialization of GitProvenance #4399

Merged
merged 5 commits into from
Aug 8, 2024

Conversation

pstreef
Copy link
Contributor

@pstreef pstreef commented Aug 8, 2024

What's changed?

Fixes a deserialization issue caused by the new constructor on GitProvenance

Anything in particular you'd like reviewers to focus on?

Is there another way to achieve this on a value class with 2 constructors without the .disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES) ?

Anyone you would like to review specifically?

no

Have you considered any alternatives or workarounds?

Changing this to an @Data. But losing immutability would be bad.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@pstreef pstreef requested a review from timtebeek August 8, 2024 09:50
@pstreef pstreef self-assigned this Aug 8, 2024
@pstreef pstreef added the bug Something isn't working label Aug 8, 2024
@pstreef pstreef merged commit 3a12433 into main Aug 8, 2024
2 checks passed
@pstreef pstreef deleted the fix/serialization-git-provenance branch August 8, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants