Add GradleDependency trait #4394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rewrite-gradle/src/main/java/org/openrewrite/gradle/trait/package-info.java
Outdated
Show resolved
Hide resolved
shanman190
force-pushed
the
feature/gradle-dependency-trait
branch
from
85c5d7a to
1e7e666
Compare
shanman190
commented
Aug 7, 2024
Comment on lines
+104
to
+113
| for (ResolvedDependency resolvedDependency : transitiveConfiguration.getResolved()) { | ||
| if ((groupId == null || matchesGlob(resolvedDependency.getGroupId(), groupId)) && | ||
| (artifactId == null || matchesGlob(resolvedDependency.getArtifactId(), artifactId))) { | ||
| Dependency req = resolvedDependency.getRequested(); | ||
| if ((req.getGroupId() == null || req.getGroupId().equals(dependency.getGroupId())) && | ||
| req.getArtifactId().equals(dependency.getArtifactId())) { | ||
| return new GradleDependency(cursor, resolvedDependency); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
callout: I wasn't quite sure what should happen here, so I opted to just return the first ResolvedDependency encountered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Added an implementation of the
Traitapi for Gradle dependenciesWhat's your motivation?
Having the same
Traitapi available for Gradle as was introduced for Maven.Anything in particular you'd like reviewers to focus on?
Nothing in particular
Anyone you would like to review specifically?
Anyone
Have you considered any alternatives or workarounds?
None
Any additional context
Checklist