Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new recipe ChangeDependencyVersionValue #4366

Closed
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
changed default value for changePropertyVersionNames in ChangeManaged…
…DependencyGroupIdAndArtifactId
marcel-gepardec committed Jul 15, 2024

Verified

This commit was signed with the committer’s verified signature. The key has expired.
nikolaybotev Nikolay Botev
commit 0807d5678e063ea3d24b61dc37a67b8633aa5648
Original file line number Diff line number Diff line change
@@ -86,11 +86,11 @@ public class ChangeManagedDependencyGroupIdAndArtifactId extends Recipe {
Boolean changePropertyVersionNames;

public ChangeManagedDependencyGroupIdAndArtifactId(String oldGroupId, String oldArtifactId, String newGroupId, String newArtifactId, @Nullable String newVersion) {
this(oldGroupId, oldArtifactId, newGroupId, newArtifactId, newVersion, null, true);
this(oldGroupId, oldArtifactId, newGroupId, newArtifactId, newVersion, null, false);
}

public ChangeManagedDependencyGroupIdAndArtifactId(String oldGroupId, String oldArtifactId, String newGroupId, String newArtifactId, @Nullable String newVersion, @Nullable String versionPattern) {
this(oldGroupId, oldArtifactId, newGroupId, newArtifactId, newVersion, versionPattern, true);
this(oldGroupId, oldArtifactId, newGroupId, newArtifactId, newVersion, versionPattern, false);
}

@JsonCreator
Original file line number Diff line number Diff line change
@@ -215,14 +215,14 @@ void changePropertyVersionManagedDependency() {
<artifactId>my-app</artifactId>
<version>1</version>
<properties>
<jakarta.activation-api.version>2.1.0</jakarta.activation-api.version>
<javax.activation.version>2.1.0</javax.activation.version>
</properties>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>jakarta.activation</groupId>
<artifactId>jakarta.activation-api</artifactId>
<version>${jakarta.activation-api.version}</version>
<version>${javax.activation.version}</version>
</dependency>
</dependencies>
</dependencyManagement>
@@ -332,7 +332,7 @@ void changePropertyVersionProfileManagedDependency() {
<artifactId>my-app</artifactId>
<version>1</version>
<properties>
<jakarta.activation-api.version>2.1.0</jakarta.activation-api.version>
<javax.activation.version>2.1.0</javax.activation.version>
</properties>
<profiles>
<profile>
@@ -342,7 +342,7 @@ void changePropertyVersionProfileManagedDependency() {
<dependency>
<groupId>jakarta.activation</groupId>
<artifactId>jakarta.activation-api</artifactId>
<version>${jakarta.activation-api.version}</version>
<version>${javax.activation.version}</version>
</dependency>
</dependencies>
</dependencyManagement>