Add recipe for adding/replacing a Maven runtime config #4363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rewrite-maven/src/main/java/org/openrewrite/maven/AddRuntimeConfig.java
Outdated
Show resolved
Hide resolved
rewrite-maven/src/test/java/org/openrewrite/maven/AddRuntimeConfigTest.java
Outdated
Show resolved
Hide resolved
…nfig.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…nfigTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rewrite-maven/src/main/java/org/openrewrite/maven/AddRuntimeConfig.java
Outdated
Show resolved
Hide resolved
timtebeek
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Great start @bmuschko ; I've added a small polishing commit, mostly to make things smaller and more idiomatic. Feel free to go over the changes and let me know if you have any question.
No need to handle configuration aliases just yet; but we can see how that turns out in practice.
…nfig.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@timtebeek Thanks for the polishing and merging. All makes sense and gives additional guidance for future PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Introduces a new recipe for adding and replacing Maven runtime configuration in
.mvn/maven.configor.mvn/jvm.config.What's your motivation?
It's important for Maven projects to standardize on certain runtime flags and make them available through checked-in files the SCM. All developers that check out the code from SCM will automatically apply those flags. For example, you may want to execute the Maven build in parallel for better build performance and therefore introduce
-T=1Cinmaven.config.Anything in particular you'd like reviewers to focus on?
=character. In fact, you will find all notations across different pieces of documentation. The implementation allows for providing this option.maven.config. Forjvm.config, you should use a whitespace. The implementation takes this into consideration.-Uvs.--update-snapshots. Please advise if you'd need this case to be handled with the initial PR and optimally "how".