fix: CreateYaml does not work the same as CreateTextFile with precondition
#4360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a precondition is present and matched, an empty file is generated but the content is not added. ``` expected: "content: yes" but was: "" ```
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rewrite-yaml/src/test/java/org/openrewrite/yaml/CreateYamlFileTest.java
Outdated
Show resolved
Hide resolved
rewrite-yaml/src/test/java/org/openrewrite/yaml/CreateYamlFileTest.java
Outdated
Show resolved
Hide resolved
pstreef
changed the title
CreateYaml does not work with preconditionCreateYaml does not work the same as CreateTextFile with precondition
…Test.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…Test.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
timtebeek
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a precondition is present and matched, an empty file is generated but the content is not added.
What's changed?
CreateYamlFilewill add content in the generate phase to work "correctly" with preconditions.What's your motivation?
Just like CreateTextFile, CreateYaml should always add content if a file is created.
Checklist
-->