-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AddOrUpdateAnnotationAttribute for values of type Class #4342
Fix AddOrUpdateAnnotationAttribute for values of type Class #4342
Conversation
Thanks a lot for this @froque ! Perhaps good to add an example where the class argument needs an import, as opposed to the java.lang imports seen now, just to be sure that's handled correctly. |
@timtebeek I am having trouble with that. Can I delegate that to you ? |
Yes sure# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- rewrite-gradle/src/main/groovy/RewriteSettings.groovy
- lines 31-36
- rewrite-xml/src/main/java/org/openrewrite/xml/style/AutodetectDebug.java
- lines 68-68
- lines 109-111
- lines 134-134
- lines 147-149
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- rewrite-gradle/src/main/groovy/RewriteSettings.groovy
- lines 31-36
- rewrite-xml/src/main/java/org/openrewrite/xml/style/AutodetectDebug.java
- lines 68-68
- lines 109-111
- lines 134-134
- lines 147-149
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for kicking this off @froque ! I've applied a few small adjustments to improve things still, removing cycles, and setting the correct type on the introduced class argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- rewrite-gradle/src/main/groovy/RewriteSettings.groovy
- lines 31-36
- rewrite-xml/src/main/java/org/openrewrite/xml/style/AutodetectDebug.java
- lines 68-68
- lines 109-111
- lines 134-134
- lines 147-149
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- rewrite-gradle/src/main/groovy/RewriteSettings.groovy
- lines 31-36
- rewrite-xml/src/main/java/org/openrewrite/xml/style/AutodetectDebug.java
- lines 68-68
- lines 109-111
- lines 134-134
- lines 147-149
What's changed?
Fixes AddOrUpdateAnnotationAttribute to work with values of type Class
What's your motivation?
Fix a bug.
Anything in particular you'd like reviewers to focus on?
No.
Anyone you would like to review specifically?
No.
Have you considered any alternatives or workarounds?
No.
Any additional context
No.
Checklist
I've used the IntelliJ IDEA auto-formatter on affected files