-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trait
interface and VariableAccess
/MethodAccess
implementation
#4309
Merged
+813
−0
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e627443
Traits interface and VariableAccess implementation
jkschneider c4a393a
Update rewrite-core/src/main/java/org/openrewrite/trait/SimpleTraitMa…
jkschneider 8a29c9c
Update rewrite-java/src/test/java/org/openrewrite/java/trait/Variable…
jkschneider e37eee3
MethodAccess
jkschneider ed7d875
Add javadocs
jkschneider cb42320
Update rewrite-java/src/test/java/org/openrewrite/java/trait/MethodAc…
jkschneider 84f7a9a
Merge branch 'main' into trait
jkschneider e7f130c
Add package-info to internal package
jkschneider baa93f6
Merge branch 'main' into trait
jkschneider 6824fdf
Update rewrite-java/src/test/java/org/openrewrite/java/trait/Variable…
jkschneider eba8e38
Update rewrite-java/src/test/java/org/openrewrite/java/trait/Variable…
jkschneider 11ef10a
Update rewrite-java/src/main/java/org/openrewrite/java/trait/MethodAc…
jkschneider ee129b1
Remove VisitFunction3
jkschneider 898ac13
Check isModifying on VariableAccess unary operator
jkschneider File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
Update rewrite-java/src/test/java/org/openrewrite/java/trait/Variable…
…AccessTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit 8a29c9cf6bb38092ab097d7919971ca3d065f379
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to add a test for the
this
andsuper
cases?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More tests are certainly warranted, but expensive in time to create. Wanted to do a quick check on whether or not this approach was even close to reasonable.