Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trait interface and VariableAccess/MethodAccess implementation #4309

Merged
merged 14 commits into from
Jul 9, 2024
+813 −0
Merged

Trait interface and VariableAccess/MethodAccess implementation #4309

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e627443
Traits interface and VariableAccess implementation
jkschneider Jul 8, 2024
c4a393a
Update rewrite-core/src/main/java/org/openrewrite/trait/SimpleTraitMa…
jkschneider Jul 8, 2024
8a29c9c
Update rewrite-java/src/test/java/org/openrewrite/java/trait/Variable…
jkschneider Jul 8, 2024
e37eee3
MethodAccess
jkschneider Jul 9, 2024
ed7d875
Add javadocs
jkschneider Jul 9, 2024
cb42320
Update rewrite-java/src/test/java/org/openrewrite/java/trait/MethodAc…
jkschneider Jul 9, 2024
84f7a9a
Merge branch 'main' into trait
jkschneider Jul 9, 2024
e7f130c
Add package-info to internal package
jkschneider Jul 9, 2024
baa93f6
Merge branch 'main' into trait
jkschneider Jul 9, 2024
6824fdf
Update rewrite-java/src/test/java/org/openrewrite/java/trait/Variable…
jkschneider Jul 9, 2024
eba8e38
Update rewrite-java/src/test/java/org/openrewrite/java/trait/Variable…
jkschneider Jul 9, 2024
11ef10a
Update rewrite-java/src/main/java/org/openrewrite/java/trait/MethodAc…
jkschneider Jul 9, 2024
ee129b1
Remove VisitFunction3
jkschneider Jul 9, 2024
898ac13
Check isModifying on VariableAccess unary operator
jkschneider Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
Update rewrite-java/src/test/java/org/openrewrite/java/trait/Variable… 
…AccessTest.java

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jkschneider @github-actions
jkschneider and github-actions[bot] authored Jul 8, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 8a29c9cf6bb38092ab097d7919971ca3d065f379
2 changes: 1 addition & 1 deletion rewrite-java/src/test/java/org/openrewrite/java/trait/VariableAccessTest.java
View file
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@
import static org.openrewrite.test.RewriteTest.toRecipe;

@SuppressWarnings("ALL")
public class VariableAccessTest implements RewriteTest {
class VariableAccessTest implements RewriteTest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add a test for the this and super cases?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More tests are certainly warranted, but expensive in time to create. Wanted to do a quick check on whether or not this approach was even close to reasonable.


@Override
public void defaults(RecipeSpec spec) {