Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle ChangeDependencyClassifier supports add and remove classifier #4268

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Gradle ChangeDependencyClassifier supports add and remove classifier #4268

merged 3 commits into from
Jun 18, 2024

Conversation

BoykoAlex
Copy link
Contributor

This is to align with Maven counter part

github-actions[bot]

This comment was marked as outdated.

Sign in to view

@timtebeek timtebeek self-requested a review June 18, 2024 12:22
@timtebeek timtebeek added the enhancement New feature or request label Jun 18, 2024
timtebeek
timtebeek approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for bringing parity to these recipes, and covering the various styles in both the recipe implementation and tests. Helps build confidence in the change. Hope this helps the recipes you're looking to write!

@timtebeek timtebeek merged commit f3f107e into openrewrite:main Jun 18, 2024
2 checks passed
crankydillo pushed a commit to crankydillo/rewrite that referenced this pull request Jul 11, 2024
@BoykoAlex @timtebeek
Gradle ChangeDependencyClassifier supports add and remove classifier (
c385dc7 
openrewrite#4268)

* Gradle `ChangeDependencyClassifier` supports add and remove classifier

* Correction

* Minor polish

---------

Co-authored-by: Tim te Beek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@timtebeek timtebeek timtebeek approved these changes

Assignees

@BoykoAlex BoykoAlex

Labels
enhancement New feature or request
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BoykoAlex @timtebeek