Add Property Resolution to RemoveRedundantDependencyVersions #4236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perty resolution, allowing dependencies/plugins using redundant property versions to correctly be removed.
timtebeek
approved these changes
Jun 7, 2024
ryan-hudson
deleted the
bugfix/remove-redundant-dependencies-property-version-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Added property version resolution for dependencies/plugins using the maven property syntax to define versions and removed the early exit logic for this case.
What's your motivation?
Redundant Dependencies and Plugin versions defined through maven properties should still be removed by this recipe instead of being ignored.