Only consider specified configurations for UpgradeTransitiveDependencies created constraints #4233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
In this version, the recipe will by default consider all transitive configurations to be adding constraints.
One can limit this behaviour by specifying constraints that need to be considered.
Eg. in the light of vulnerability patching, a recipe runner might only be interested in running against
runtime
jars.That would be feasible by specifying both default runtime available configurations(implementation, runtimeOnly) + any manually added transitive ones.
Anything in particular you'd like reviewers to focus on?
This change will only have impact if a configurations list was specified. We reintroduce/combine earlier behaviour by checking for the extendsFrom + must be transitive.
Added some test cases to further explain expectations/behaviour.
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
See #4230 for a blacklist approach
Any additional context
Our preference goes towards a whitelist approach as that list is afaik better maintainable for wide usage of plugins, custom configurations...
Checklist