refactor: OpenRewrite best practices #4151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.recipes.OpenRewriteBestPractices?organizationId=T3BlblJld3JpdGU%3D Co-authored-by: Moderne <[email protected]>
|
@mike-solomon didn't get to finishing this earlier; would you be able to help add example values for the 21 TODO comments inserted here? |
timtebeek
commented
Apr 26, 2024
rewrite-core/src/main/java/org/openrewrite/FindParseFailures.java
Outdated
Show resolved
Hide resolved
rewrite-gradle/src/main/java/org/openrewrite/gradle/AddProperty.java
Outdated
Show resolved
Hide resolved
rewrite-gradle/src/main/java/org/openrewrite/gradle/UpdateGradleWrapper.java
Outdated
Show resolved
Hide resolved
|
@timtebeek Yep - I believe I fixed all open TODOs. Please let me know if you run into any issues with these. I'm not actually sure how this will appear but I did my best to put in examples as I found them in tests or online. |
timtebeek
commented
Apr 26, 2024
sambsnyd
pushed a commit
that referenced
this pull request
Apr 29, 2024
* refactor: OpenRewrite best practices Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.recipes.OpenRewriteBestPractices?organizationId=T3BlblJld3JpdGU%3D Co-authored-by: Moderne <[email protected]> * Apply suggestions from code review * Fix TODOs in AddRepository * Fix TODOs in RemoveRepository * Resolve more TODOs --------- Co-authored-by: Moderne <[email protected]> Co-authored-by: $(git --no-pager log --format=format:'%an' -n 1) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.recipes.OpenRewriteBestPractices?organizationId=T3BlblJld3JpdGU%3D