Instead of throwing most MavenDownloadingException, record them into … #4140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the resolution result. This allows for partial success when processing poms which are invalid or contain unresolvable dependencies without hiding the existence of these problems.
jkschneider
approved these changes
Apr 19, 2024
jkschneider
reviewed
Apr 19, 2024
| @@ -66,6 +66,12 @@ public class RawPom { | |||
| @Nullable | |||
| String version; | |||
|
|
|||
| // This is an obsolete field that is no longer used, but it is present in some particularly old POMs | |||
| @EqualsAndHashCode.Include | |||
There was a problem hiding this comment.
Not sure it should be included in EqualsAndHashCode
jkschneider
reviewed
Apr 19, 2024
| } | ||
|
|
||
| @JsonCreator | ||
| ResolvedPom(Pom requested, Iterable<String> activeProfiles, Map<String, String> properties, List<ResolvedManagedDependency> dependencyManagement, @Nullable List<MavenRepository> initialRepositories, List<MavenRepository> repositories, List<Dependency> requestedDependencies, List<Plugin> plugins, List<Plugin> pluginManagement) { |
There was a problem hiding this comment.
This worries me. Where is the constructor going?
There was a problem hiding this comment.
After this PR there are no remaining invocations of the two-argument form of the constructor within OpenRewrite.
So if the two-argument constructor is gone the remaining constructor is exactly what lombok would generate, so there is no need to preserve it explicitly.
anandfresh
approved these changes
May 22, 2024
|
Closing this for now in favor of fixing resolution problems. Allowing a partial POM resolution will cause the downstream effect of dependency-manipulating recipes potentially not working correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the resolution result. This allows for partial success when processing poms which are invalid or contain unresolvable dependencies without hiding the existence of these problems.
What's changed?
What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist