Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare XML tag names for equality #3251

Merged
merged 1 commit into from
May 16, 2023
Merged

Compare XML tag names for equality #3251

merged 1 commit into from
May 16, 2023

Conversation

timtebeek
Copy link
Contributor

Fixes #3250

@timtebeek timtebeek added the bug Something isn't working label May 16, 2023
@timtebeek timtebeek requested a review from knutwannheden May 16, 2023 09:44
@timtebeek timtebeek self-assigned this May 16, 2023
knutwannheden
knutwannheden approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@knutwannheden knutwannheden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@timtebeek timtebeek merged commit 4e00ff4 into main May 16, 2023
@timtebeek timtebeek deleted the tim/compare_xml_tag_names branch May 16, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knutwannheden knutwannheden knutwannheden approved these changes

Assignees

@timtebeek timtebeek

Labels
bug Something isn't working
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SemanticallyEqualVisitor does not detect changed tags in child elements
2 participants
@timtebeek @knutwannheden