-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite 8.0 migration recipes #3241
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recipe to migrate rewrite 8.
ticket: #3234
These recipes have been tested on repo
rewrite-static-analysis
(branch) which is before the rewrite8 migration.This PR covers below features
getVisitor()
toTreeVisitor<?, ExecutionContext>
, because that is what Preconditions returnsJavaSourceFile visitJavaSourceFile(JavaSourceFile cu, ExecutionContext ctx)
toJ visit(@Nullable Tree tree, ExecutionContext ctx)
Applicability.of()
->Preconditions.of()
, andApplicability.and()
->Preconditions.and()
rewrite-static-analysis
JavaTemplate.Builder#javaParser(Supplier<JavaParser>)
method no longer exists. Jonathan created a recipe to migrate it toJavaTemplate.Builder#javaParser(JavaParser.Builder)
, but I think that recipe needs to be extended a bit, in case theSupplier<JavaParser>
is represented by a variable or fieldTreeVisitor.doNext(..)
is removed, leave a comment to replace withTreeVisitor.doAfterVisit(..)
or follow the instruction.spec.recipe(X.doNext(Y)
) tospec.recipes(X, Y)
org.openrewrite.marker.Markers#SearchResult()
andorg.openrewrite.marker.Markers.searchResult(@Nullable String description)
are deprecated and removed, useSearchResult.found()
instead.Gradlenot sure whether it should be part of rewrite 8 migrationChangeJavaCompatibility
was renamed toUpdateJavaCompatibility
with slightly different arguments in Feature/gradle/enhance update java compatibility #3238